[PATCH] - Popen() uses os.execvp() by default so the output redirection doesn't work unless shell=True is used, then the command string is execute through the shell.

[Flavio Leitner]

---
 cas |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/cas b/cas
index e380203..3245adb 100755
--- a/cas
+++ b/cas
@@ -228,8 +228,8 @@ class CasApplication(object):
                                      CRASH_32)
             self.casLog.info("Current machine suitable for processing 32 bit core,
"\
                              "running crash.")
-            cmd = "cd " + os.path.join(self.storagePath) + " &&
./crash -i crash.in > crash.out"
-            cmdPipe = Popen([cmd], stdout=PIPE, stderr=PIPE)
+            cmd = "./crash -i crash.in > crash.out"
+            cmdPipe = Popen([cmd], stdout=PIPE, stderr=PIPE, shell=True)
             cmdData = cmdPipe.communicate()
             # pull status code to verify crash even ran to completeness
             sts, out, err = (cmdPipe.returncode, cmdData[0].strip(),
@@ -242,8 +242,8 @@ class CasApplication(object):
             casProcessMachine = platform.uname()[1]
             # The machine is suitable for processing the core through crash.
             self.casLog.info("Current machine suitable for processing core, running
crash.")
-            cmd = "cd " + os.path.join(self.storagePath) + " &&
./crash -i crash.in > crash.out"
-            cmdPipe = Popen([cmd], stdout=PIPE, stderr=PIPE)
+            cmd = "./crash -i crash.in > crash.out"
+            cmdPipe = Popen([cmd], stdout=PIPE, stderr=PIPE, shell=True)
             cmdData = cmdPipe.communicate()
             # pull status code to verify crash even ran to completeness
             sts, out, err = (cmdPipe.returncode, cmdData[0].strip(),
-- 
1.6.2.3

[Adam Stokes]

----- "Flavio Leitner" <fleitner(a)redhat.com&gt; wrote:

>  ---
>   cas |    8 ++++----
>   1 files changed, 4 insertions(+), 4 deletions(-)
>  
>  diff --git a/cas b/cas
>  index e380203..3245adb 100755
>  --- a/cas
>  +++ b/cas
>  @@ -228,8 +228,8 @@ class CasApplication(object):
>                                        CRASH_32)
>               self.casLog.info("Current machine suitable for processing
>  32 bit core, "\
>                                "running crash.")
>  -            cmd = "cd " + os.path.join(self.storagePath) + " &&
>  ./crash -i crash.in > crash.out"
>  -            cmdPipe = Popen([cmd], stdout=PIPE, stderr=PIPE)
>  +            cmd = "./crash -i crash.in > crash.out"
>  +            cmdPipe = Popen([cmd], stdout=PIPE, stderr=PIPE,
>  shell=True)
>               cmdData = cmdPipe.communicate()
>               # pull status code to verify crash even ran to
>  completeness
>               sts, out, err = (cmdPipe.returncode, cmdData[0].strip(),
>  @@ -242,8 +242,8 @@ class CasApplication(object):
>               casProcessMachine = platform.uname()[1]
>               # The machine is suitable for processing the core through
>  crash.
>               self.casLog.info("Current machine suitable for processing
>  core, running crash.")
>  -            cmd = "cd " + os.path.join(self.storagePath) + " &&
>  ./crash -i crash.in > crash.out"
>  -            cmdPipe = Popen([cmd], stdout=PIPE, stderr=PIPE)
>  +            cmd = "./crash -i crash.in > crash.out"
>  +            cmdPipe = Popen([cmd], stdout=PIPE, stderr=PIPE,
>  shell=True)
>               cmdData = cmdPipe.communicate()
>               # pull status code to verify crash even ran to
>  completeness
>               sts, out, err = (cmdPipe.returncode, cmdData[0].strip(),
>  -- 
>  1.6.2.3
>  
>  _______________________________________________
>  cas mailing list
>  cas(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/cas 
committed
-- 
        __          __                
.-----.|  |_.-----.|  |--.-----.-----.
|__ --||   _|  _  ||    <|  -__|__ --|
|_____||____|_____||__|__|_____|_____|
 .----------------------------------.
(   ajs(a)redhat.com || 919.754.4187   )
 `----------------------------------'