[PATCH] cas: fixed crash script generation when CRASH_32 is detected.

[Flavio Leitner]

This patch fixes cas to generate 'crash' script using CRASH_32
binary and use it later when processing the vmcore.

Signed-off-by: Flavio Leitner <fleitner(a)redhat.com&gt;
---
 cas |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/cas b/cas
index dd7faeb..144f191 100755
--- a/cas
+++ b/cas
@@ -224,10 +224,10 @@ class CasApplication(object):
         if debugKernelArch == "i686" and CRASH_32 is not None:
             # 32bit crash on same system.
             self.util.buildCrashFile(self.storagePath, corefile, debugKernel,
-                                     CRASH_32)
+                                     crash_bin=CRASH_32)
             self.casLog.info("Current machine suitable for processing 32 bit core,
"\
                              "running crash.")
-            cmd = "%s -i crash.in > crash.out" % (CRASH_32,)
+            cmd = "./crash -i crash.in > crash.out"
             cmdPipe = Popen([cmd], stdout=PIPE, stderr=PIPE, shell=True)
             cmdData = cmdPipe.communicate()
             # pull status code to verify crash even ran to completeness
-- 
1.6.2.3

[Adam Stokes]

----- "Flavio Leitner" <fleitner(a)redhat.com&gt; wrote:

>  This patch fixes cas to generate 'crash' script using
> CRASH_32
>  binary and use it later when processing the vmcore.
>  
>  Signed-off-by: Flavio Leitner <fleitner(a)redhat.com&gt;
>  ---
>   cas |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>  
>  diff --git a/cas b/cas
>  index dd7faeb..144f191 100755
>  --- a/cas
>  +++ b/cas
>  @@ -224,10 +224,10 @@ class CasApplication(object):
>           if debugKernelArch == "i686" and CRASH_32 is not None:
>               # 32bit crash on same system.
>               self.util.buildCrashFile(self.storagePath, corefile,
>  debugKernel,
>  -                                     CRASH_32)
>  +                                     crash_bin=CRASH_32)
>               self.casLog.info("Current machine suitable for processing
>  32 bit core, "\
>                                "running crash.")
>  -            cmd = "%s -i crash.in > crash.out" % (CRASH_32,)
>  +            cmd = "./crash -i crash.in > crash.
>               cmdPipe = Popen([cmd], stdout=PIPE, stderr=PIPE,
>  shell=True)
>               cmdData = cmdPipe.communicate()
>               # pull status code to verify crash even ran to
>  completeness
>  -- 
>  1.6.2.3
>  
>  _______________________________________________
>  cas mailing list
>  cas(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/cas 
Nice catch, was late last night when i was doing modifications lol
-- 
        __          __                
.-----.|  |_.-----.|  |--.-----.-----.
|__ --||   _|  _  ||    <|  -__|__ --|
|_____||____|_____||__|__|_____|_____|
 .----------------------------------.
(   ajs(a)redhat.com || 919.754.4187   )
 `----------------------------------'