Author: croberts
Date: 2011-09-29 18:47:16 +0000 (Thu, 29 Sep 2011)
New Revision: 5029
Modified:
trunk/cumin/python/cumin/grid/tags.py
Log:
Adding some defense against potentially null objects.
Modified: trunk/cumin/python/cumin/grid/tags.py
===================================================================
--- trunk/cumin/python/cumin/grid/tags.py 2011-09-28 19:44:35 UTC (rev 5028)
+++ trunk/cumin/python/cumin/grid/tags.py 2011-09-29 18:47:16 UTC (rev 5029)
@@ -160,7 +160,10 @@
'''
def render_title(self, session):
obj = self.object.get(session)
- return obj.name
+ if obj is not None:
+ return obj.name
+ else:
+ return ""
def add_details_tab(self):
pass
@@ -926,7 +929,9 @@
given_tag = self.form.tags.input.param.get(session)
tag_object = self.app.wallaby.get_tag_by_name(given_tag)
- selected_features = tag_object.features
+ selected_features = list()
+ if tag_object is not None:
+ selected_features = tag_object.features
for i, feature in enumerate(items):
selected = ""
@@ -972,10 +977,13 @@
def render_inputs(self, session, *args):
tag = self.form.tags.get(session)
- value = ", ".join(self.app.wallaby.get_tag_by_name(tag).features)
- if not value or value == "":
- value = "No features currently selected"
- value = truncate_text(value, 50, True)
+ value = ""
+ tag_obj = self.app.wallaby.get_tag_by_name(tag)
+ if tag_obj is not None:
+ value = ", ".join(tag_obj.features)
+ if not value or value == "":
+ value = "No features currently selected"
+ value = truncate_text(value, 50, True)
return value
def render_title(self, session):
@@ -1131,7 +1139,10 @@
tag_id = osession.values_by_path["main.grid.tag.id"]
self.form.tags.set(session, tag_id)
features = "No features currently assigned"
- feature_list = self.app.wallaby.get_tag_by_name(tag_id).features
+ tag = self.app.wallaby.get_tag_by_name(tag_id)
+ feature_list = list()
+ if tag is not None:
+ feature_list = tag.features
if len(feature_list) > 0:
features = ", ".join(feature_list)
self.form.feature_name.set(session, features)
Show replies by date