azure-sdk-for-go goipath issue

[Mikel Olasagasti]

Hello team,

Newer version or rclone requires a newer release of azure-sdk-for-go,
but azure-sdk-for-go has been divided into different modules, all
living in a monorepo and thus requiring new packages.

Each of the modules has its own release and I can create packages
using version and tag:

Version:                1.3.0
%global tag             sdk/internal/v1.3.0

Each release contains the whole repo at that tag point. I can build a
module by removing all unneeded modules/files and keeping only
required files for the current module that is being packaged.

The main problem is that all packages have the same goipath:

%global goipath         github.com/Azure/azure-sdk-for-go/

If I change the goipath to
`github.com/Azure/azure-sdk-for-go/sdk/internal` for example, the
resulting package is completely wrong as expected.

I can keep `github.com/Azure/azure-sdk-for-go/` and use goaltipaths
with `github.com/Azure/azure-sdk-for-go/sdk/internal`, but then all
the packages would have `github.com/Azure/azure-sdk-for-go/` as their
goipath and this causes conflicts (at least in my tests).

Any idea of how this could be solved?

Kind regards,
Mikel

[Mikel Olasagasti]

Hi team,

It seems it's simpler than expected.

Setting different goliath to each module and then moving the module
files to the root does the trick.

https://github.com/mikelolasagasti/azure-golang

I've checked that rclone and restic are able to build using these
specs. The only problem is that tests fail for these packages due to
the paths used.

I'll push the packages for review. Any feedback is appreciated.

Kind regards,
Mikel

Hau idatzi du Mikel Olasagasti ([e-mail]) erabiltzaileak
(2023 eka. 19(a), al. (15:10)):
> Hello team,
>
> Newer version or rclone requires a newer release of azure-sdk-for-go,
> but azure-sdk-for-go has been divided into different modules, all
> living in a monorepo and thus requiring new packages.
>
> Each of the modules has its own release and I can create packages
> using version and tag:
>
> Version:                1.3.0
> %global tag             sdk/internal/v1.3.0
>
> Each release contains the whole repo at that tag point. I can build a
> module by removing all unneeded modules/files and keeping only
> required files for the current module that is being packaged.
>
> The main problem is that all packages have the same goipath:
>
> %global goipath         github.com/Azure/azure-sdk-for-go/
>
> If I change the goipath to
> `github.com/Azure/azure-sdk-for-go/sdk/internal` for example, the
> resulting package is completely wrong as expected.
>
> I can keep `github.com/Azure/azure-sdk-for-go/` and use goaltipaths
> with `github.com/Azure/azure-sdk-for-go/sdk/internal`, but then all
> the packages would have `github.com/Azure/azure-sdk-for-go/` as their
> goipath and this causes conflicts (at least in my tests).
>
> Any idea of how this could be solved?
>
> Kind regards,
> Mikel

[Mark Edward Fuller]

Thanks for figuring that out and sharing the solution
> On 20 Jun 2023, at 18:58, Mikel Olasagasti  wrote:
>
> Hi team,
>
> It seems it's simpler than expected.
>
> Setting different goliath to each module and then moving the module
> files to the root does the trick.
>
> https://github.com/mikelolasagasti/azure-golang
>
> I've checked that rclone and restic are able to build using these
> specs. The only problem is that tests fail for these packages due to
> the paths used.
>
> I'll push the packages for review. Any feedback is appreciated.
>
> Kind regards,
> Mikel
>
> Hau idatzi du Mikel Olasagasti ([e-mail]) erabiltzaileak
> (2023 eka. 19(a), al. (15:10)):
> > Hello team,
> >
> > Newer version or rclone requires a newer release of azure-sdk-for-go,
> > but azure-sdk-for-go has been divided into different modules, all
> > living in a monorepo and thus requiring new packages.
> >
> > Each of the modules has its own release and I can create packages
> > using version and tag:
> >
> > Version:                1.3.0
> > %global tag             sdk/internal/v1.3.0
> >
> > Each release contains the whole repo at that tag point. I can build a
> > module by removing all unneeded modules/files and keeping only
> > required files for the current module that is being packaged.
> >
> > The main problem is that all packages have the same goipath:
> >
> > %global goipath         github.com/Azure/azure-sdk-for-go/
> >
> > If I change the goipath to
> > `github.com/Azure/azure-sdk-for-go/sdk/internal` for example, the
> > resulting package is completely wrong as expected.
> >
> > I can keep `github.com/Azure/azure-sdk-for-go/` and use goaltipaths
> > with `github.com/Azure/azure-sdk-for-go/sdk/internal`, but then all
> > the packages would have `github.com/Azure/azure-sdk-for-go/` as their
> > goipath and this causes conflicts (at least in my tests).
> >
> > Any idea of how this could be solved?
> >
> > Kind regards,
> > Mikel
>
> golang mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedoraproject.org/archives/list/[e-mail]
> Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue

Mark Edward Fuller