gotmax23 opened a new pull-request against the project: `go-rpm-macros` that you are following: `` Add additional gobuildflags macros ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/62
gotmax23 commented on the pull-request: `Add additional gobuildflags macros` that you are following: `` See https://src.fedoraproject.org/rpms/aerc/pull-request/6 for example usage. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/62
ngompa commented on the pull-request: `Add additional gobuildflags macros` that you are following: `` You mean `$GO_LDFLAGS`? ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/62
ngompa commented on the pull-request: `Add additional gobuildflags macros` that you are following: `` Does this supersede #41? ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/62
gotmax23 commented on the pull-request: `Add additional gobuildflags macros` that you are following: ``
You mean `$GO_LDFLAGS`?
Yes. Thanks!
Does this supersede #41?
I think so. I really want to avoid pushing breaking changes to macros without a deprecation period. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/62
gotmax23 commented on the pull-request: `Add additional gobuildflags macros` that you are following: `` @ngompa, PTAL ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/62
gotmax23 commented on the pull-request: `Add additional gobuildflags macros` that you are following: `` `-trimpath` apparently breaks debuginfo collection, so I'll drop that commit... ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/62
gotmax23 commented on the pull-request: `Add additional gobuildflags macros` that you are following: `` Okay, I did my normal build a hundred random Go packages that currently build successfully according to Koschei routine in https://copr.fedorainfracloud.org/coprs/gotmax23/go-rpm-macros-3.4.0_3.20240..., so this should be good to go. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/62
gotmax23 merged a pull-request against the project: `go-rpm-macros` that you are following.
Merged pull-request:
`` Add additional gobuildflags macros ``
golang@lists.fedoraproject.org
-
Maxwell G -
Neal Gompa