https://bugzilla.redhat.com/show_bug.cgi?id=1166312
Bug ID: 1166312 Summary: etcd unit should support command line options Product: Fedora Version: 21 Component: etcd Assignee: lacypret@gmail.com Reporter: lars@redhat.com QA Contact: extras-qa@fedoraproject.org CC: eparis@redhat.com, golang@lists.fedoraproject.org, jchaloup@redhat.com, lacypret@gmail.com, lemenkov@gmail.com
The "etcd.service" unit distributed with Fedora 21 (atomic) does not contain any facilities for passing arguments to etcd. That is, it looks like this:
[Service] Type=simple StandardOutput=null WorkingDirectory=/var/lib/etcd User=etcd ExecStart=/usr/bin/etcd
This means that if a deployer wants to pass arguments to etcd at boot (such as a discovery URL), the only option is to introduce a new unit file in /etc/systemd/system.
This works, but it seems like a heavy hammer.
It seems as if a better choice would be to introduce an EnvironmentFile directive like we do for so many other units. Something like:
[Service] Type=simple StandardOutput=null WorkingDirectory=/var/lib/etcd User=etcd EnvironmentFile=/etc/sysconfig/etcd ExecStart=/usr/bin/etcd $OPTIONS
https://bugzilla.redhat.com/show_bug.cgi?id=1166312
--- Comment #1 from Eric Paris eparis@redhat.com --- etcd (at least 0.4) has a config file. /etc/etcd/etcd.conf
Which is sourced and used by etcd itself.
This might go away in 0.5 or 0.6, in which case we will look to support the model you describe. But right now, I don't see a bug here.
https://bugzilla.redhat.com/show_bug.cgi?id=1166312
Lars Kellogg-Stedman lars@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|etcd unit should support |RFE: etcd unit should |command line options |support command line | |options
--- Comment #2 from Lars Kellogg-Stedman lars@redhat.com --- I thought that the config file *was* going away in 0.5 (rather than "might"), so I figured that preparing for that in advance would mean that people would be able to transition from 0.4.6 to 0.5.x with fewer changes. But consider this an RFE rather than a bug, I guess.
https://bugzilla.redhat.com/show_bug.cgi?id=1166312
Jan Chaloupka jchaloup@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2015-04-13 15:52:37
--- Comment #3 from Jan Chaloupka jchaloup@redhat.com --- Since etcd-2.0.* (already updated in f20-rawhide) has introduces environment file (path is the same, content of /etc/etcd/etcd.conf has changed), we can close this bug as resolved in the current release.
https://bugzilla.redhat.com/show_bug.cgi?id=1166312
Jan Chaloupka jchaloup@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |etcd-2.0.3-0.2
golang@lists.fedoraproject.org