zbyszek opened a new pull-request against the project: `go-rpm-macros` that you are following: `` Use $SOURCE_DATE_EPOCH instead of random bytes ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/63
gotmax23 commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` This PR and https://pagure.io/go-rpm-macros/pull-request/62 conflict, so one of them will have to be rebased. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/63
gotmax23 commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` @alexsaezm, @jcajka, PTAL ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/63
zbyszek commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` If #62 is merged first, I'll rebase… ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/63
gotmax23 commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` Is it possible for `$SOURCE_DATE_EPOCH` to be undefined? Should this have a fallback or at least change to `${SOURCE_DATE_EPOCH-}` (in case a packager uses `set -u` or such)? ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/63
zbyszek commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` I think in the Fedora case, SOURCE_DATE_EPOCH would always be defined. But you're right, it's probably better to provide a fallback like for other variables. I changed it to use `:-`. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/63
gotmax23 commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` Cool. Thanks! Can you please rebase this now that other PR has been merged? This flag has no moved to the `%gobuild_ldflags` definition. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/63
gotmax23 commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` Cool. Thanks! Can you please rebase this now that other PR has been merged? This flag has no moved to the `%gobuild_ldflags` definition. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/63
zbyszek commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` Rebased. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/63
alexsaezm commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` +1 I like the idea. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/63
gotmax23 merged a pull-request against the project: `go-rpm-macros` that you are following.
Merged pull-request:
`` Use $SOURCE_DATE_EPOCH instead of random bytes ``
gotmax23 commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` Thanks! ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/63
zbyszek commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` I tested this with `osbuild-composer-102-1.fc41`. I still get a difference, but I think it must be caused by something else. Looking at the build log [1]: `+ go build -buildmode pie -compiler gc '-tags=rpm_crashtraceback ' -a -v -x -ldflags ' -X '''github.com/osbuild/osbuild-composer/internal/common.RpmVersion=osbuild-composer-102-1.fc41.x86_64''' -X github.com/osbuild/osbuild-composer/version=102 -B 0xf36d4ab9ce0d4697e7c7f22d606899e6b457eff8 -compressdwarf=false -linkmode=external -extldflags '''-Wl,-z,relro -Wl,--as-needed -Wl,-z,pack-relative-relocs -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld-errors -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -Wl,--build-id=sha1 -specs=/usr/lib/rpm/redhat/redhat-package-notes '''' -o _bin/osbuild-composer github.com/osbuild/osbuild-composer/cmd/osbuild-composer` and locally `+ go build -buildmode pie -compiler gc '-tags=rpm_crashtraceback ' -a -v -x -ldflags ' -X '''github.com/osbuild/osbuild-composer/internal/common.RpmVersion=osbuild-composer-102-1.fc41.x86_64''' -X github.com/osbuild/osbuild-composer/version=102 -B 0xf36d4ab9ce0d4697e7c7f22d606899e6b457eff8 -compressdwarf=false -linkmode=external -extldflags '''-Wl,-z,relro -Wl,--as-needed -Wl,-z,pack-relative-relocs -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld-errors -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -Wl,--build-id=sha1 -specs=/usr/lib/rpm/redhat/redhat-package-notes '''' -o _bin/osbuild-composer github.com/osbuild/osbuild-composer/cmd/osbuild-composer`
So I think the build flags are working as expected.
[1] https://kojipkgs.fedoraproject.org//packages/osbuild-composer/102/1.fc41/dat... ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/63
zbyszek commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` https://pagure.io/fedora-reproducible-builds/project/issue/15 for the follow-up. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/63
golang@lists.fedoraproject.org
-
Alejandro Sáez Morollón -
Maxwell G
-
Zbigniew Jędrzejewski-Szmek