On Tue, Jan 29, 2019 at 6:49 AM Troy Dawson tdawson@redhat.com wrote:
On Tue, Jan 29, 2019 at 6:07 AM Jared K. Smith jsmith@fedoraproject.org wrote:
- Nothing seems to be showing that the dependencies are bundled. At a minimum, I would expect a long list of lines that look something like: "Provides: bundled(nodejs-abab)=1.0.4", "Provides: bundled(nodejs-abbrev)=1.1.1", etc. See https://fedoraproject.org/wiki/Bundled_Software_policy for the bundled software policy itself.
Yep, I'm still working on getting this working, and pulling things out. I'll do that step at the end. But thank you for the link.
- I would assume that at least *some* of the necessary dependencies are already in Fedora -- if so, we should use those if possible instead of using the bundled versions, and if there's a reason we can't use the system version, we should document it in the spec file.
I can try to find more, the one's I have listed in the Requires are the "binary" packages.
Here's a fun fact. gateway depends on 1000 node_modules (exactly I believe) I was able to unbundle 455 of those packages. Ya!! Of course, that means that I have to have 455 lines of "Requires:" and 545 lines of "Provides: bundled()" in the spec file Ya!!?? This spec file just went from a lightweight to a sumo wrestler in one day.
Troy