[jpirko/libteam] fe6e12: teamd: fix incorrect usage of sizeof in __str_sock...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/jpirko/libteam
  Commit: fe6e12e1fb9dbcd5a50bc80c3ba55ee25a3ef0f1
      https://github.com/jpirko/libteam/commit/fe6e12e1fb9dbcd5a50bc80c3ba55ee2...
  Author: Jiri Pirko <jiri(a)resnulli.us&gt;
  Date:   2014-08-06 (Wed, 06 Aug 2014)

  Changed paths:
    M teamd/teamd_link_watch.c
    M teamd/teamd_link_watch.h
    M teamd/teamd_lw_arp_ping.c
    M teamd/teamd_lw_nsna_ping.c

  Log Message:
  -----------
  teamd: fix incorrect usage of sizeof in __str_sockaddr

Sizeof will return the size of a pointer, which is not correct intended.

Introduced-by: 672ddfd506 ("teamd: move arp ping link watcher to a separate
file")
Signed-off-by: Jiri Pirko <jiri(a)resnulli.us&gt;


  Commit: 87f57116b914e5b7c7539f87f85d92d351a0c63d
      https://github.com/jpirko/libteam/commit/87f57116b914e5b7c7539f87f85d92d3...
  Author: Jiri Pirko <jiri(a)resnulli.us&gt;
  Date:   2014-08-06 (Wed, 06 Aug 2014)

  Changed paths:
    M include/private/misc.h

  Log Message:
  -----------
  fix strncmp len in ifname2ifindex

Calling strncpy with a maximum size argument of 16 bytes on destination
array "ifr.ifr_ifrn.ifrn_name" of size 16 bytes might leave the
destination string unterminated.

Introduced-by: b9692cb90 ("teamd: generate team device names in case they are not
specified")
Signed-off-by: Jiri Pirko <jiri(a)resnulli.us&gt;


  Commit: b883f38bcc0bb1affe9b0273843e7996529714d4
      https://github.com/jpirko/libteam/commit/b883f38bcc0bb1affe9b0273843e7996...
  Author: Jiri Pirko <jiri(a)resnulli.us&gt;
  Date:   2014-08-06 (Wed, 06 Aug 2014)

  Changed paths:
    M teamd/teamd_lw_tipc.c

  Log Message:
  -----------
  teamd: tipc: use TIPC_MAX_*_NAME for buffers and check len

You might overrun the 255 byte fixed-size string "tipc_ppriv->bearer" by
copying "tipc_bearer" without checking the length.

Introduced-by: 847046a5c7 ("teamd: add TIPC link watcher")
Signed-off-by: Jiri Pirko <jiri(a)resnulli.us&gt;


Compare: https://github.com/jpirko/libteam/compare/4bc21806dabd...b883f38bcc0b