On Dec. 5, 2013, 3:18 p.m., Jan Safranek wrote:
> mof/LMI_Storage-BlockStorage.mof, line 602
>
<
http://reviewboard-openlmi.rhcloud.com/r/1333/diff/1/?file=6866#file6866l...
>
> Just for the record: this change breaks API.
>
> We talked about it outside review board and there *will be* subsequent patches
which will fix it (CreateOrModifyLV will create both thin and plain LVs).
After some thinking, this patch probably won't be necessary. I'll leave this
review open for now, until the final patchset is submitted.
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1333/#review1909
-----------------------------------------------------------
On Dec. 5, 2013, 11:51 a.m., Jan Synacek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1333/
-----------------------------------------------------------
(Updated Dec. 5, 2013, 11:51 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Make LMI_LVStorageExtent a common superclass.
This change is a preparation for thin provisioning support.
Diffs
-----
mof/70_LMI_Storage-Profiles.mof be68b2b1d1033618e505608ab49bd7a76b21b774
mof/LMI_Storage-BlockStorage.mof 0601e64fd026566637ddd73fc0bd245708d5b957
mof/LMI_Storage-MethodParameters.mof cd3cacff1ad2ff12e72d81f1406ca8ed03ccb95b
mof/LMI_Storage.reg 7a07f824b2c3e689f86a1dd6658d84e8f8c200e9
src/lmi/storage/LMI_LVStorageExtent.py c4f258121396807f60fe9e269a9f1ad59fd20113
src/lmi/storage/LMI_StorageConfigurationService.py
a0ba2b1ac048575d1b3989a4d4336bd70fa5b389
src/lmi/storage/cimom_entry.py ea7783dc1b31def4f48126e6a3c0925c5bfad5fd
test/test_unused.py 96624b1eb1fe9738805437f3ecfae2b06710f0b7
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1333/diff/
Testing
-------
Basic testing via yawn.
Thanks,
Jan Synacek