https://bugzilla.redhat.com/show_bug.cgi?id=1118240
Bug ID: 1118240 Summary: puic4 is broken: fix provided Product: Fedora Version: 20 Component: perl-Qt Assignee: iarnell@gmail.com Reporter: olivier.lahaye1@free.fr QA Contact: extras-qa@fedoraproject.org CC: iarnell@gmail.com, ltinkl@redhat.com, perl-devel@lists.fedoraproject.org
Created attachment 917029 --> https://bugzilla.redhat.com/attachment.cgi?id=917029&action=edit Fixes puic4 code generator.
Description of problem: puic4 the UI perl compiler for Qt is completely broken. Here are 2 patches that fixes most problems. The 1st one attached in this comment is mainly (but not exclusively) for the Qt3Support4 fixes. (upstream issue #46) The secondone in next comment will partially fix issue #44.
Version-Release number of selected component (if applicable): all perl-Qt-0.96.0* including latest SVN. for rhel-*-* or fedora-*-*
How reproducible: puic4 -o Ui_file.pm file.ui where file.ui was generated for Qt3. For exemple: http://svn.oscar.openclustergroup.org/oscar/pkgsrc/netbootmgr/trunk/netbootm...
Steps to Reproduce: 1. wget http://svn.oscar.openclustergroup.org/oscar/pkgsrc/netbootmgr/trunk/netbootm... 2. puic4 -o Ui_NetBootMgr.pm netbootmgr.ui 3. perl -d NetBootMgr.pl or just look at the syntax for "__item" and also missing ending semicolons.
Actual results: unusable perl syntax.
Expected results: valid perl code.
Additional info: Upstream AUTHOR is aware of the patch but won't be able to push it before a few weeks. Once dones, he has planed to make a new release. - http://search.cpan.org/dist/Qt/ is a dead repo - git clone https://code.google.com/p/perlqt4/ is the official standalone repo - git clone git://anongit.kde.org/perlqt/ is the active repo from kdebinding project.
Note that standalone repo has been resynced back from kdebindings repo to include perl-5.18 fixes Also note thet changes in CMAkelists.txt have an impact: - can't build on rhel6 - need a smokeqt that has smokeqwt lib. IMHO, this shouldn't be required, thus I think that add ing my 2 patches is sufficient for the moment. The Author will give a look at the cmake issues later. https://code.google.com/p/perlqt4/issues/list
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
--- Comment #1 from Olivier LAHAYE olivier.lahaye1@free.fr --- Created attachment 917030 --> https://bugzilla.redhat.com/attachment.cgi?id=917030&action=edit Fixes partially 'puic4 -x' generated code
This patch fixes the header generation and the additional code generated by the -x option of puic4.
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
Fedora Admin XMLRPC Client fedora-admin-xmlrpc@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|iarnell@gmail.com |extras-orphan@fedoraproject | |.org
--- Comment #2 from Fedora Admin XMLRPC Client fedora-admin-xmlrpc@redhat.com --- This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component.
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
Fedora Admin XMLRPC Client fedora-admin-xmlrpc@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|extras-orphan@fedoraproject |psabata@redhat.com |.org |
--- Comment #3 from Fedora Admin XMLRPC Client fedora-admin-xmlrpc@redhat.com --- This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component.
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
--- Comment #4 from Fedora End Of Life endoflife@fedoraproject.org --- This message is a reminder that Fedora 20 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 20. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '20'.
Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version.
Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 20 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above.
Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
Olivier LAHAYE olivier.lahaye1@free.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|20 |22
--- Comment #5 from Olivier LAHAYE olivier.lahaye1@free.fr --- Still valid for fedora-21 at least.
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
Petr Å abata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #6 from Petr Å abata psabata@redhat.com --- Ack.
The new repositories appear to be fairly dead too. I'll take a look at your patches and, provided they look reasonable :), merge them so our puic4 is somewhat less unusable for the time being.
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
Fedora Admin XMLRPC Client fedora-admin-xmlrpc@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|psabata@redhat.com |extras-orphan@fedoraproject | |.org
--- Comment #7 from Fedora Admin XMLRPC Client fedora-admin-xmlrpc@redhat.com --- This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component.
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
Fedora Admin XMLRPC Client fedora-admin-xmlrpc@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|extras-orphan@fedoraproject |ppisar@redhat.com |.org |
--- Comment #8 from Fedora Admin XMLRPC Client fedora-admin-xmlrpc@redhat.com --- This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component.
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
--- Comment #9 from Petr Pisar ppisar@redhat.com --- I will apply the "Fixes partially 'puic4 -x' generated code" patch. I cannot apply "Fixes puic4 code generator" because it requires many changes from upstream after the 0.69.0 release and my attempt to back ported them caused failing some tests.
I will rebase perl-Qt to latest KDE release in Fedora 25 and hopefully in Fedora 24. But I will not push the rebase into older stable Fedoras.
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- perl-Qt-0.96.0-19.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-5d5b739142
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- perl-Qt-0.96.0-17.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-18ca71f650
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- perl-Qt-0.96.0-14.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-27bf0fbc49
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
--- Comment #13 from Petr Pisar ppisar@redhat.com --- I'm finishing packaging 4.14.3 version and I have to inform you that despite both you patches were merged by upstream, the semicolons are still missing in generated Ui_NetBootMgr.pm.
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- perl-Qt-4.14.3-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b44c8de86c
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- perl-Qt-4.14.3-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b44c8de86c
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- perl-Qt-0.96.0-14.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-27bf0fbc49
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- perl-Qt-0.96.0-17.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-18ca71f650
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- perl-Qt-4.14.3-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8052a09647
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- perl-Qt-0.96.0-18.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8bce2346c2
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- perl-Qt-0.96.0-15.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6ccdbda73a
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- perl-Qt-4.14.3-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8052a09647
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- perl-Qt-0.96.0-15.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6ccdbda73a
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
--- Comment #23 from Fedora Update System updates@fedoraproject.org --- perl-Qt-0.96.0-18.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8bce2346c2
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
--- Comment #24 from Fedora Update System updates@fedoraproject.org --- perl-Qt-4.14.3-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
--- Comment #25 from Fedora Update System updates@fedoraproject.org --- perl-Qt-0.96.0-19.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-fc47ca605f
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
--- Comment #26 from Fedora Update System updates@fedoraproject.org --- perl-Qt-0.96.0-16.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-481f17ba6e
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #27 from Fedora Update System updates@fedoraproject.org --- perl-Qt-0.96.0-16.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-481f17ba6e
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
--- Comment #28 from Fedora Update System updates@fedoraproject.org --- perl-Qt-0.96.0-19.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-fc47ca605f
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
--- Comment #29 from Fedora Update System updates@fedoraproject.org --- perl-Qt-0.96.0-19.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
--- Comment #30 from Fedora Update System updates@fedoraproject.org --- perl-Qt-0.96.0-16.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1118240
Fedora End Of Life jkurik@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |EOL Last Closed| |2016-07-19 07:55:04
--- Comment #31 from Fedora End Of Life jkurik@fedoraproject.org --- Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug.
If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug.
Thank you for reporting this bug and we are sorry it could not be fixed.
perl-devel@lists.fedoraproject.org