[Bug 544738] New: cpanspec doesn't escape "/" in --filter-requires leading to bad sed statements

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: cpanspec doesn't escape "/" in --filter-requires leading to bad sed statements

https://bugzilla.redhat.com/show_bug.cgi?id=544738

Summary: cpanspec doesn't escape "/" in --filter-requires
                    leading to bad sed statements
           Product: Fedora
           Version: 12
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: cpanspec
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
    Classification: Fedora

Description of problem:
cpanspec translates each "--filter-requires some_string" into a corresponding
sed statement in the corresponding perl-<module>-requires.sh of form:
    -e '/^some-string$/d'

However, when some_string is a path which then contains a slash "/", this
causes the sed statement to mess up.

In particular, one of the fuse modules I was compiling had some example perl
scripts which began with the line "#/usr/bin/perl." This caused the build to
then require "/usr/bin/perl" which I wanted to eliminate. When I added
"--filter-requires /usr/bin/perl", it caused *all* the sed statements to fail
with the error:
    sed: -e expression #1, char 4: unknown command: `u'

Either the documentation should warn that "/" must be escaped or *better*, the
script should automatically escape the forward slashes since the user has no
reason to think that "/" is a special character (and indeed, sed could have
used just about any character to demarcate the s program)

[Bug 544738] cpanspec doesn't escape "/" in --filter-requires leading to bad sed statements

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=544738

--- Comment #1 from Need Real Name  2010-01-18 20:17:01 EST ---
Is anybody following these bug reports?
It has been 6 weeks since this was reported!!!

[Bug 544738] cpanspec doesn't escape "/" in --filter-requires leading to bad sed statements

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=544738

--- Comment #2 from Marcela Mašláňová  2010-01-19 02:28:35 EST ---
Maintainer and upstream of this package is working on it in his free time. Feel
free to help and propose a patch.

[Bug 544738] cpanspec doesn't escape "/" in --filter-requires leading to bad sed statements

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=544738

--- Comment #3 from Need Real Name  2010-01-19 22:54:57 EST ---
Thanks for the update - my query was not a complaint as much as just trying to
find out if anybody out there was following this bug.

Although I am no Perl expert, I believe that Perl has some very useful
paradigms for making sure that regex's are appropriately quoted.

Incidentally, it is a bit ironic that this perl-oriented program (it is
cpan2spec afterall) uses 'sed' rather than more powerful 'perl' paradigms to
filter. Switching to perl should be simple and would solve the problem using
something like the \Q...\E expression.

[Bug 544738] cpanspec doesn't escape "/" in --filter-requires leading to bad sed statements

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=544738

--- Comment #4 from Bug Zapper  2010-11-04 00:11:23 EDT ---

This message is a reminder that Fedora 12 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 12.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '12'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 12's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 12 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

[Bug 544738] cpanspec doesn't escape "/" in --filter-requires leading to bad sed statements

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=544738

Bug Zapper  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |WONTFIX
               Flag|needinfo?(bugzilla@kosowsky |
                   |.org)                       |
        Last Closed|                            |2010-12-03 21:08:32

--- Comment #5 from Bug Zapper  2010-12-03 21:08:32 EST ---

Fedora 12 changed to end-of-life (EOL) status on 2010-12-02. Fedora 12 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.

[Bug 544738] cpanspec doesn't escape "/" in --filter-requires leading to bad sed statements

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=544738

Steven Pritchard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |ASSIGNED
            Version|12                          |rawhide
         Resolution|WONTFIX                     |
           Keywords|                            |Reopened

--- Comment #6 from Steven Pritchard  2010-12-07 15:01:58 EST ---
Re-opening...  This is still a valid bug that I'll try to get to ASAP.

[Bug 544738] cpanspec doesn't escape "/" in --filter-requires leading to bad sed statements

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=544738

Petr Šabata  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]             |[e-mail]

[Bug 544738] cpanspec doesn't escape "/" in --filter-requires leading to bad sed statements

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=544738

--- Comment #8 from Petr Šabata  ---
Created attachment 954521
  --> https://bugzilla.redhat.com/attachment.cgi?id=954521&action=edit
Escape slashes in filters

[Bug 544738] cpanspec doesn't escape "/" in --filter-requires leading to bad sed statements

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=544738

Petr Šabata  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://github.com/silug/cp
                   |                            |anspec/pull/6

[Bug 544738] cpanspec doesn't escape "/" in --filter-requires leading to bad sed statements

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=544738

--- Comment #9 from Petr Šabata  ---
Patch accepted upstream.

[Bug 544738] cpanspec doesn't escape "/" in --filter-requires leading to bad sed statements

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=544738

--- Comment #10 from Fedora Update System  ---
cpanspec-1.78-19.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/cpanspec-1.78-19.fc21

[Bug 544738] cpanspec doesn't escape "/" in --filter-requires leading to bad sed statements

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=544738

--- Comment #11 from Fedora Update System  ---
cpanspec-1.78-19.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/cpanspec-1.78-19.fc20

[Bug 544738] cpanspec doesn't escape "/" in --filter-requires leading to bad sed statements

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=544738

--- Comment #12 from Fedora Update System  ---
cpanspec-1.78-19.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/cpanspec-1.78-19.fc19

[Bug 544738] cpanspec doesn't escape "/" in --filter-requires leading to bad sed statements

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=544738

--- Comment #13 from Fedora Update System  ---
cpanspec-1.78-19.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/cpanspec-1.78-19.el6

[Bug 544738] cpanspec doesn't escape "/" in --filter-requires leading to bad sed statements

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=544738

--- Comment #14 from Fedora Update System  ---
cpanspec-1.78-19.fc20 has been pushed to the Fedora 20 stable repository.  If
problems still persist, please make note of it in this bug report.

[Bug 544738] cpanspec doesn't escape "/" in --filter-requires leading to bad sed statements

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=544738

--- Comment #15 from Fedora Update System  ---
cpanspec-1.78-19.fc21 has been pushed to the Fedora 21 stable repository.  If
problems still persist, please make note of it in this bug report.

[Bug 544738] cpanspec doesn't escape "/" in --filter-requires leading to bad sed statements

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=544738

--- Comment #16 from Fedora Update System  ---
cpanspec-1.78-19.fc19 has been pushed to the Fedora 19 stable repository.  If
problems still persist, please make note of it in this bug report.

[Bug 544738] cpanspec doesn't escape "/" in --filter-requires leading to bad sed statements

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=544738

--- Comment #17 from Fedora Update System  ---
cpanspec-1.78-19.el6 has been pushed to the Fedora EPEL 6 stable repository. 
If problems still persist, please make note of it in this bug report.

[Bug 544738] cpanspec doesn't escape "/" in --filter-requires leading to bad sed statements

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=544738

--- Comment #18 from Fedora End Of Life  ---
This message is a notice that Fedora 19 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 19. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained. Approximately 4 (four) weeks from now this bug will
be closed as EOL if it remains open with a Fedora 'version' of '19'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 19 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

[Bug 544738] cpanspec doesn't escape "/" in --filter-requires leading to bad sed statements

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=544738

Petr Šabata  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
   Fixed In Version|                            |cpanspec-1.78-19.fc19
         Resolution|---                         |CURRENTRELEASE
        Last Closed|2010-12-03 21:08:32         |2015-01-12 09:06:50