[PATCH] Mark language search string translatable. (#955229)
by Samantha N. Bueno
---
pyanaconda/ui/gui/spokes/welcome.glade | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pyanaconda/ui/gui/spokes/welcome.glade b/pyanaconda/ui/gui/spokes/welcome.glade
index f0a4602..4f79b7c 100644
--- a/pyanaconda/ui/gui/spokes/welcome.glade
+++ b/pyanaconda/ui/gui/spokes/welcome.glade
@@ -367,7 +367,7 @@
<property name="invisible_char">●</property>
<property name="invisible_char_set">True</property>
<property name="secondary_icon_name">edit-clear-symbolic</property>
- <property name="placeholder_text">Type here to search.</property>
+ <property name="placeholder_text" translatable="yes">Type here to search.</property>
<signal name="changed" handler="on_entry_changed" swapped="no"/>
<signal name="icon-release" handler="on_clear_icon_clicked" swapped="no"/>
</object>
--
1.7.11.7
10 years, 4 months
[master] Hook for checking BZ IDs in commit messages
by Vratislav Podzimek
The following patch adds a git hook that can be used to ensure all commits that
are about to be pushed on some rhelX-branch reference proper RHEL bugs.
I didn't bothered with updating, patching or tweaking the commit-msg hook
because I think we could remove it and use the pre-push hook instead. If we want
to keep them both, it would be nice to have parts of their code shared, but for
now it seems like an unnecessary extra work to me.
Vratislav Podzimek (1):
pre-push hook checking bugzilla IDs on rhelX branches
docs/commit-log.txt | 5 +++
scripts/githooks/check_commit_msg.sh | 70 +++++++++++++++++++++++++++++++++
scripts/githooks/pre-push | 76 ++++++++++++++++++++++++++++++++++++
3 files changed, 151 insertions(+)
create mode 100755 scripts/githooks/check_commit_msg.sh
create mode 100755 scripts/githooks/pre-push
--
1.8.5.3
10 years, 4 months
[PATCH] Add a sidebar to the standalone windows (#1045250)
by Máirín Duffy
This adds a sidebar to the left of the standalone windows. The reason
for this is to visually reinforce the left-to-right linear nature of
the standalone windows. There is a variable (sidebar_width_percentage)
you can set to control the percentage width of the screen that the
sidebar occupies - I've set it to 18% which seems reasonable. It auto-
centers the logo on top of the sidebar as well. There are three layers
to the sidebar: the base color, a texture pixbuf, and the logo pixbuf
on top.
---
widgets/src/StandaloneWindow.c | 67 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 67 insertions(+)
diff --git a/widgets/src/StandaloneWindow.c b/widgets/src/StandaloneWindow.c
index a770bc7..87ed03d 100644
--- a/widgets/src/StandaloneWindow.c
+++ b/widgets/src/StandaloneWindow.c
@@ -70,8 +70,75 @@ static void anaconda_standalone_window_realize(GtkWidget *widget,
G_DEFINE_TYPE(AnacondaStandaloneWindow, anaconda_standalone_window, ANACONDA_TYPE_BASE_WINDOW)
+static int get_sidebar_width(GtkWidget *window) {
+ GtkAllocation allocation;
+ /* change value below to make sidebar bigger / smaller */
+ float sidebar_width_percentage = .18;
+ gtk_widget_get_allocation(window, &allocation);
+ return allocation.width * sidebar_width_percentage;
+}
+
+static int get_sidebar_height(GtkWidget *window) {
+ GtkAllocation allocation;
+ gtk_widget_get_allocation(window, &allocation);
+ return allocation.height;
+}
+
+/* function to override default drawing to insert sidebar image */
+gboolean anaconda_standalone_window_on_draw(GtkWidget *win, cairo_t *cr) {
+
+ /* Create sidebar */
+ GTK_WIDGET_CLASS(anaconda_standalone_window_parent_class)->draw(win,cr);
+ cairo_rectangle(cr, 0, 0, get_sidebar_width(win), get_sidebar_height(win));
+
+ /* Configure sidebar base color */
+ /* Dark grey for RHEL: 65/255.0, 65/255.0, 62/255.0, 1 */
+ /* Blue for Fedora: 60/255.0, 110/255.0, 180/255.0, 1 */
+ cairo_set_source_rgba(cr, 65/255.0, 65/255.0, 62/255.0, 1);
+ cairo_fill_preserve(cr);
+
+ /* Configure sidebar texture image */
+ GdkPixbuf *pixbuf_background = gdk_pixbuf_new_from_file("/usr/share/anaconda/pixmaps/noise-texture.png", NULL);
+ cairo_surface_t *surface= gdk_cairo_surface_create_from_pixbuf(pixbuf_background, 0, gtk_widget_get_window(GTK_WIDGET(win)));
+ cairo_set_source_surface(cr, surface, 0, 0);
+ cairo_pattern_set_extend(cairo_get_source(cr), CAIRO_EXTEND_REPEAT);
+ cairo_fill(cr);
+
+ /* Configure logo image overlaid on sidebar */
+ GdkPixbuf *pixbuf_logo = gdk_pixbuf_new_from_file("/usr/share/anaconda/pixmaps/redhat-logo.png", NULL);
+ if (pixbuf_logo != NULL) {
+ double x_value = (get_sidebar_width(win) - gdk_pixbuf_get_width(pixbuf_logo))/2;
+ double y_value = 20;
+ cairo_surface_t *surface= gdk_cairo_surface_create_from_pixbuf(pixbuf_logo, 0, gtk_widget_get_window(GTK_WIDGET(win)));
+ cairo_set_source_surface(cr, surface, x_value, y_value);
+ cairo_rectangle(cr, x_value, y_value, gdk_pixbuf_get_width(pixbuf_logo), gdk_pixbuf_get_height(pixbuf_logo));
+ cairo_fill(cr);
+ }
+ return TRUE; /* TRUE to avoid default draw handler */
+}
+
+/* Move base window content appropriate amount of space to the right to make room for sidebar */
+static void anaconda_standalone_window_size_allocate (GtkWidget *window, GtkAllocation *allocation) {
+ GtkAllocation child_allocation;
+ GtkWidget *child;
+
+ gtk_widget_set_allocation(window, allocation);
+ int sidebar_width = get_sidebar_width(window);
+ child_allocation.x = allocation->x+sidebar_width;
+ child_allocation.y = allocation->y;
+ child_allocation.width = allocation->width-sidebar_width;
+ child_allocation.height = allocation->height;
+
+ child = gtk_bin_get_child (GTK_BIN (window));
+ if (child && gtk_widget_get_visible (child))
+ gtk_widget_size_allocate (child, &child_allocation);
+}
+
static void anaconda_standalone_window_class_init(AnacondaStandaloneWindowClass *klass) {
GObjectClass *object_class = G_OBJECT_CLASS(klass);
+ GtkWidgetClass *widget_class = GTK_WIDGET_CLASS(klass);
+ widget_class->draw=anaconda_standalone_window_on_draw;
+ widget_class->size_allocate=anaconda_standalone_window_size_allocate;
klass->quit_clicked = NULL;
klass->continue_clicked = NULL;
--
1.8.4.2
10 years, 4 months
[anaconda:rhel7/master] Check RAID10 box for BTRFS (#1021856)
by Anne Mulhern
Resolves: rhbz#1021856
Note: I edited this by hand rather than through glade because if I edit
it through glade none of the values are visible, i.e., editing through glade
causes a bug.
Signed-off-by: mulhern <amulhern(a)redhat.com>
---
pyanaconda/ui/gui/spokes/custom.glade | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pyanaconda/ui/gui/spokes/custom.glade b/pyanaconda/ui/gui/spokes/custom.glade
index 8d014c0..c5686e1 100644
--- a/pyanaconda/ui/gui/spokes/custom.glade
+++ b/pyanaconda/ui/gui/spokes/custom.glade
@@ -2232,7 +2232,7 @@ until you click on the main menu's 'Begin Installation' button.</property>
<col id="0" translatable="yes">RAID10 <span foreground="grey">(Performance, Redundancy)</span></col>
<col id="1">False</col>
<col id="2">True</col>
- <col id="3">False</col>
+ <col id="3">True</col>
<col id="4">True</col>
</row>
</data>
--
1.8.3.1
10 years, 4 months
[PATCH] various patches
by Chris Lumens
#1-3 are all against RHEL7, but of those only #2 needs to go to rhel7-branch
right now. I suppose the others could in the future. #4 fixes a pylint
caught problem.
- Chris
10 years, 4 months
[blivet:rhel7/master] Don't add None value to req_disks (#981316)
by Anne Mulhern
Resolves: rhbz#981316
If a disk has been removed in the interim it won't be found by a lookup
in the device tree, but we don't want to include None in our copy.
Signed-off-by: mulhern <amulhern(a)redhat.com>
---
blivet/__init__.py | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/blivet/__init__.py b/blivet/__init__.py
index 1f6637f..1236511 100644
--- a/blivet/__init__.py
+++ b/blivet/__init__.py
@@ -1961,11 +1961,8 @@ class Blivet(object):
continue
# update the refs in req_disks as well
- req_disks = []
- for disk in partition.req_disks:
- req_disks.append(new.devicetree.getDeviceByID(disk.id))
-
- partition.req_disks = req_disks
+ req_disks = (new.devicetree.getDeviceByID(disk.id) for disk in partition.req_disks)
+ partition.req_disks = [disk for disk in req_disks if disk is not None]
p = partition.disk.format.partedDisk.getPartitionByPath(partition.path)
partition.partedPartition = p
--
1.8.3.1
10 years, 4 months
[blivet:rhel7/master] Make error message more informative (#1022497)
by Anne Mulhern
Resolves: rhbz#1022497
Make the error message indicate the nature of the problem a little better so
that it is less misleading when it pops up in the GUI.
Making the error message indicate the precise problem is actually kind of
tricky, since it would involve changing the return values for
getNextPartitionType() to record this information
and then propagating those values carefully througout
a large chunk of allocatePartitions().
Signed-off-by: mulhern <amulhern(a)redhat.com>
---
blivet/partitioning.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/blivet/partitioning.py b/blivet/partitioning.py
index abaf1b3..33bda27 100644
--- a/blivet/partitioning.py
+++ b/blivet/partitioning.py
@@ -1064,7 +1064,7 @@ def allocatePartitions(storage, disks, partitions, freespace):
break
if free is None:
- raise PartitioningError(_("not enough free space on disks"))
+ raise PartitioningError(_("unable to allocate a large enough partition"))
_disk = use_disk
disklabel = _disk.format
--
1.8.3.1
10 years, 4 months
[PATCH] cppcheck the C files
by David Shea
New test to run a static analyzer on the C code. There's not a whole lot to
complain about in the C code (unless we turn on the really picky extensions),
but the unusedFunction check did point out that we can dump about half of isys,
so that's handy.
10 years, 4 months
[anaconda:rhel7/master] Remove unused import (#1022497)
by Anne Mulhern
Related: rhbz#1022497
Because it is distracting.
Signed-off-by: mulhern <amulhern(a)redhat.com>
---
pyanaconda/ui/gui/spokes/custom.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py
index 7560b31..31cf948 100644
--- a/pyanaconda/ui/gui/spokes/custom.py
+++ b/pyanaconda/ui/gui/spokes/custom.py
@@ -57,7 +57,6 @@ from blivet.devicefactory import get_raid_level
from blivet.devicefactory import SIZE_POLICY_AUTO
from blivet.devicefactory import SIZE_POLICY_MAX
from blivet import findExistingInstallations
-from blivet.partitioning import doPartitioning
from blivet.partitioning import doAutoPartition
from blivet.errors import StorageError
from blivet.errors import NoDisksError
--
1.8.3.1
10 years, 4 months
[rhel7-branch/master][PATCH] Do not add step for realmd if we are not gonna run it (#1058755)
by Vratislav Podzimek
Otherwise the progress bar won't reach the 100 % if no AP/IPA is configured to
be discovered.
Signed-off-by: Vratislav Podzimek <vpodzime(a)redhat.com>
---
pyanaconda/install.py | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/pyanaconda/install.py b/pyanaconda/install.py
index c8181a3..7ad47c7 100644
--- a/pyanaconda/install.py
+++ b/pyanaconda/install.py
@@ -121,9 +121,14 @@ def doInstall(storage, payload, ksdata, instClass):
# those are the ones that take the most time.
steps = len(storage.devicetree.findActions(type="create", object="format")) + \
len(storage.devicetree.findActions(type="resize", object="format"))
- steps += 6
- # pre setup phase, packages setup, packages, bootloader, realmd,
- # post install
+
+ # pre setup phase, packages setup, packages, bootloader, post install
+ steps += 5
+
+ # joining AD/IPA domain
+ if ksdata.realm.join_realm:
+ steps += 1
+
progressQ.send_init(steps)
# This should be the only thread running, wait for the others to finish if not.
--
1.8.5.3
10 years, 4 months