[jpirko/libteam] 146849: teamd: LACP runner does not set Agg bit on first s...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/jpirko/libteam
  Commit: 14684953b1e50a9359d2cc38c5e35d5c36796ac8
      https://github.com/jpirko/libteam/commit/14684953b1e50a9359d2cc38c5e35d5c...
  Author: Jamie Bainbridge <jamie.bainbridge(a)gmail.com&gt;
  Date:   2016-06-19 (Sun, 19 Jun 2016)

  Changed paths:
    M teamd/teamd_runner_lacp.c

  Log Message:
  -----------
  teamd: LACP runner does not set Agg bit on first slave

teamd's LACP runner does not set the INFO_STATE_AGGREGATION bit when
there is only one slave in a team. This results in LACPDUs not being
sent with this flag set, and the team never negotiates. A Cisco Nexus
5500 switch will report the switchport in "(s)uspended" state.

This can be reproduced on some systems by booting with a LACP team with
more than one port, or by slowly adding ports to a new team on the
commandline.

Change the check from "more than 1 port" to "more than zero ports" so
that all LACP runner slaves have this bit set.

Resolves https://github.com/jpirko/libteam/issues/15

Tested-by: Customer
Signed-off-by: Jamie Bainbridge <jamie.bainbridge(a)gmail.com&gt;
Signed-off-by: Jiri Pirko <jiri(a)mellanox.com&gt;